fix transforming sortable items#114
Open
yonathan06 wants to merge 1 commit into
Open
Conversation
|
@martinpengellyphillips, hi! Thank you for the library! Could you please merge this one so that dragging elements of different heights will work? |
This is really a very important part of the functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I experienced an issue where sortable items with different heights were not transformed properly
The issue was that the delta was calculated as target.x - current.x (or target.y - current.y)
the delta was the diff between an item and the one before/after them, instead of the size of the dragged item
Changed it to transform based on the size of the dragged item
here is a reproduction repo https://stackblitz.com/edit/solidjs-templates-atuhev